Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump mongodb to 6.5.0 #290

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Bump mongodb to 6.5.0 #290

merged 2 commits into from
Sep 16, 2024

Conversation

Bharat94389
Copy link
Contributor

@Bharat94389 Bharat94389 commented Apr 6, 2024

see #218

Changes done:

  • bump mongodb to 6.5.0
  • updated mongo config

@DABH can you please have a look at this PR

@KoshelevS
Copy link

@DABH Is it possible to merge this PR?

@DABH
Copy link
Contributor

DABH commented Sep 3, 2024

I can merge this but need to think about versioning. Since default options are changing, this feels like it should be a major version release of winston-mongodb. Do you folks agree?

@yurijmikhalevich
Copy link
Member

@DABH, I agree.

@KoshelevS
Copy link

Sure. No problem.

@DABH
Copy link
Contributor

DABH commented Sep 15, 2024

@Bharat94389 Any chance you can rebase this PR so I can merge it? (Or any other volunteers?)

@Bharat94389
Copy link
Contributor Author

@DABH updated the PR please have a look

@DABH
Copy link
Contributor

DABH commented Sep 15, 2024

@Bharat94389 Thanks for updating! It looks like there's now a test failure that doesn't occur on master. Perhaps you have to just do npm install ip -g --save on your branch? Anyway, should be good to merge once we get the tests passing again... thanks again for helping get this done!

@Bharat94389
Copy link
Contributor Author

@DABH tried installing ip globally but didn't work so added as a dev package, and ran all the testcases locally as well.

@DABH
Copy link
Contributor

DABH commented Sep 16, 2024

Whoops, don't know why I typed -g, sorry, muscle memory! Looks like tests are passing now so I will merge. Thank you again!

@DABH DABH merged commit da74841 into winstonjs:master Sep 16, 2024
9 checks passed
@DABH
Copy link
Contributor

DABH commented Sep 16, 2024

Hey @yurijmikhalevich could I please get write permissions for the NPM repo https://www.npmjs.com/package/winston-mongodb so I can push out this major release? Thanks! (I'm dabh on NPM)

@DABH
Copy link
Contributor

DABH commented Sep 24, 2024

@yurijmikhalevich sorry to pester, but gentle bump on the above - any help is appreciated :)

@yurijmikhalevich
Copy link
Member

@DABH, done. Thank you! :)

@yurijmikhalevich
Copy link
Member

FYI @indexzero

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants