Support wiremock v3 #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielFran
force-pushed
the
wiremock-chart-1.0.0
branch
2 times, most recently
from
e061f00
to
e7deadd
Compare
- Update image version and index - Update readme with instructions to use helm repository - Update notes and readme with port-forward instructions - Switch to Helm v2 - Substitute WIREMOCK_OPTION by args - Cleanup _helpers.tpl - Support additional pod annotations - Update configmaps - Update service - Fix ingress - Add imagePullSecrets support - Add service account support - Add pod and container security context support - Add horizontal pod autoscaler support - Update CI and CD pipelines Fix wiremock#21 Fix wiremock#22 Fix wiremock#25 Fix wiremock#27 Fix wiremock#28 Fix wiremock#34 Fix wiremock#40 Close wiremock#29 Close wiremock#31 Close wiremock#33 Close wiremock#39
DanielFran
force-pushed
the
wiremock-chart-1.0.0
branch
from
e7deadd
to
53202e1
Compare
|
@gitkent should I keep it as version 1.0.0 or 0.3.0? |
@DanielFran I think it is good time to bump to 1.0.0 given we have quite a number of changes, helm is now v2, wiremock is now v3. Post this we can follow major.minor.patch for helm chart version. |
gitkent
approved these changes
Jul 8, 2024
|
@leeturner Is it OK to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
References
imagePullSecrets+ bug in ingress.yaml #34imagePullSecrets, cleanup usinghelpers.tpl#33Submitter checklist
#help-contributingor a project-specific channel like#wiremock-javacc @gitkent @oleg-nenashev