i18n(id) Update components.mdx #1782
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
i18n
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
Thanks for the contribution 🙌
I left a few comments on the PR but this is looking really great 👍
Something I noticed in this PR, is that heading level 3 in the "Built-in components" section, e.g. ### Tabs, ### Cards, etc., are usually translated as they do not need to match component names. Do you think this is something that would make sense in this specific case? Totally fine if you think it's not necessary or would make the documentation less clear. Just wanted to bring it up in case you think it's a good idea and would like to make the change.
| Setiap `<TabItem>` harus memiliki `label` untuk ditampilkan kepada pengguna. | ||
| Gunakan atribut opsional `icon` untuk mengikutsertakan salah satu [ikon bawaan Starlight ](#semua-icon) disamping label. | ||
|
|
||
| ```mdx | ||
| import { Tabs, TabItem } from '@astrojs/starlight/components'; |
There was a problem hiding this comment.
I cannot suggest a change for it but the example below is missing the icons from https://github.com/withastro/starlight/pull/1568/files#diff-bde0eef3b5aa6eb8762ac30b4992c55505bc9eb0373f4a05d81f58f39c05e3bd
| @@ -69,7 +70,7 @@ import { Tabs, TabItem } from '@astrojs/starlight/components'; | |||
| </Tabs> | |||
| ``` | |||
|
|
|||
| Kode di atas akan menampilkan tab seperti berikut pada halaman: | |||
| Kode di atas akan menampilkan tab-tab berikut pada halaman: | |||
|
|
|||
| <Tabs> | |||
There was a problem hiding this comment.
Same for this example regarding icons.
| @@ -163,6 +164,198 @@ import { LinkCard } from '@astrojs/starlight/components'; | |||
| <LinkCard title="Komponen" href="/id/guides/components/" /> | |||
| </CardGrid> | |||
|
|
|||
| ### Aside | |||
|
|
|||
| _Aside_ (dikenal juga sebagai “_admonition_” or “_callout_”) berguna untuk menampilkan informasi sekunder di samping konten utama halaman. | |||
There was a problem hiding this comment.
I assume there is no better word than the English "aside" one that would fit here and be well understood? Not an issue, it's perfectly fine, just asking for curiosity and you definitely know what is best.
|
|
||
| The following syntax can be used to customize the appearance of the file tree: |
There was a problem hiding this comment.
| The following syntax can be used to customize the appearance of the file tree: |
This is probably something forgotten.
|
|
||
| <FileTree> | ||
|
|
||
| - astro.config.mjs an **important** file |
There was a problem hiding this comment.
Do you think it would make sense to translate the "an important file comment". We did it in other languages so if we can, I think it could help a bit. Let me know what you think.
|
|
||
| <FileTree> | ||
|
|
||
| - astro.config.mjs an **important** file |
There was a problem hiding this comment.
Same question as the previous comment, if we translate it above, we need to update this one.
|
Hi @yudyananda are you still interested in updating this page? Let us know if you have any issues with @HiDeoo’s suggested changes! |
|
Thanks again for opening this PR @yudyananda — as we haven’t seen any updates recently, I’ll close this PR so it doesn’t get stale, but happy to receive any future PRs if you have time! |
Description
Updating outdated and fix small error in translation