-
-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: deprecated Astro.props.slug
→ Astro.props.id
#2685
docs: deprecated Astro.props.slug
→ Astro.props.id
#2685
Conversation
|
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR 🙌
I left a suggestion to the code change but great catch.
I wasn't sure whether or not I needed to modify also the translated files. Please tell me if I need also to modify the other files.
This is perfect, we usually avoid when possible to modify the translated files as updating them could mark them as updated even though they're not.
Co-authored-by: HiDeoo <494699+HiDeoo@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, thanks for the quick update 🌟
Astro.props.slug
→ Astro.props.entry.slug
Astro.props.slug
→ Astro.props.id
Description
While migrating some projects to Astro v5 (+ Starlight), building the website showed warning messages that
Astro.props.slug
is deprecated (still works right now).If I'm not wrong,
Astro.props.slug
can be safely replaced byAstro.props.entry.slug
.This PR applies this change in Starlight documentation in the
docs/src/content/docs/guides/overriding-components.mdx
override example.Note: I wasn't sure whether or not I needed to modify also the translated files. Please tell me if I need also to modify the other files.
This PR doesn't contain any changesets as it's a documentation modification only.