Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Storybook, Confluence and Jira social icons #2732

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Sidnioulz
Copy link

Description

Adds three icons: Storybook, Confluence and Jira

image

Copy link

changeset-bot bot commented Dec 20, 2024

🦋 Changeset detected

Latest commit: f038a76

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Dec 20, 2024
Copy link

netlify bot commented Dec 20, 2024

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit f038a76
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/6765be756120540008e89720
😎 Deploy Preview https://deploy-preview-2732--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Collaborator

Hello! Thank you for opening your first PR to Starlight! ✨

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🤩

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Sidnioulz! All looks great to me — just suggested one small optimisation.

packages/starlight/components/Icons.ts Outdated Show resolved Hide resolved
.changeset/purple-rivers-joke.md Outdated Show resolved Hide resolved
Sidnioulz and others added 2 commits December 20, 2024 19:58
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
@Sidnioulz Sidnioulz requested a review from delucis December 20, 2024 18:59
@Sidnioulz
Copy link
Author

Thanks for the review @delucis! I did send the icons through SVGOMG but I'm quite conservative with precision rounding so I didn't optimise them as much as you did :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants