-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Menu APIs #2887
Open
wix-docs-feds
wants to merge
17
commits into
master
Choose a base branch
from
expandable-menu
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Menu APIs #2887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes: Service $w.Button property label.examples[0] has changed body Service $w.MenuContainer operation onItemClick was removed Service $w.MenuContainer operation onItemDblClick was removed Service $w.MenuContainer operation onItemMouseIn was removed Service $w.MenuContainer operation onItemMouseOut was removed issues: Message ViewChangeEventOptions has an unknown property type * (ApppointmentFieldEvent.js (8)) Operation postMessage has an unknown param type * (HtmlComponent.js (97)) Property data has an unknown type * (HtmlComponentMessageEvent.js (16)) Property fileLimit has mismatching types for get (number) and set (string) (UploadButton.js (128, 149)) Operation set has an unknown param type * (window-frontend.js (201)) Operation get has an unknown return type * (window-frontend.js (234)) Operation set has an unknown param type * (window.js (235)) Operation get has an unknown return type * (window.js (269)) Callback ViewChangeOperation is defined two or more times (AppointmentField.js (347), DatePicker.js (472)) Callback ViewChangeOperation has an unknown return type * (AppointmentField.js (347)) Callback ViewChangeEventHandler is defined two or more times (AppointmentField.js (362), DatePicker.js (466)) Callback Validator has an unknown param type * (ValidatableMixin.js (143)) Property value has an unknown type * (ValueMixin.js (62)) Property value has an unknown type * (ValueMixin.js (89))
… issue detected issues: Message ViewChangeEventOptions has an unknown property type * (ApppointmentFieldEvent.js (8)) Operation postMessage has an unknown param type * (HtmlComponent.js (97)) Property data has an unknown type * (HtmlComponentMessageEvent.js (16)) Property fileLimit has mismatching types for get (number) and set (string) (UploadButton.js (128, 149)) Operation set has an unknown param type * (window-frontend.js (201)) Operation get has an unknown return type * (window-frontend.js (234)) Operation set has an unknown param type * (window.js (235)) Operation get has an unknown return type * (window.js (269)) Callback ViewChangeOperation is defined two or more times (AppointmentField.js (347), DatePicker.js (472)) Callback ViewChangeOperation has an unknown return type * (AppointmentField.js (347)) Callback ViewChangeEventHandler is defined two or more times (AppointmentField.js (362), DatePicker.js (466)) Callback Validator has an unknown param type * (ValidatableMixin.js (143)) Property value has an unknown type * (ValueMixin.js (62)) Property value has an unknown type * (ValueMixin.js (89))
changes: Service $w.MenuContainer is new Service $w.MenuItemMouseEvent is new issues: Message ViewChangeEventOptions has an unknown property type * (ApppointmentFieldEvent.js (8)) Operation postMessage has an unknown param type * (HtmlComponent.js (97)) Property data has an unknown type * (HtmlComponentMessageEvent.js (16)) Property fileLimit has mismatching types for get (number) and set (string) (UploadButton.js (128, 149)) Operation set has an unknown param type * (window-frontend.js (201)) Operation get has an unknown return type * (window-frontend.js (234)) Operation set has an unknown param type * (window.js (235)) Operation get has an unknown return type * (window.js (269)) Callback ViewChangeOperation is defined two or more times (AppointmentField.js (347), DatePicker.js (472)) Callback ViewChangeOperation has an unknown return type * (AppointmentField.js (347)) Callback ViewChangeEventHandler is defined two or more times (AppointmentField.js (362), DatePicker.js (466)) Callback Validator has an unknown param type * (ValidatableMixin.js (143)) Property value has an unknown type * (ValueMixin.js (62)) Property value has an unknown type * (ValueMixin.js (89))
changes: Service $w.MenuContainer property menuItems was removed Service $w.MenuContainer message MenuItem was removed issues: Message ViewChangeEventOptions has an unknown property type * (ApppointmentFieldEvent.js (8)) Operation postMessage has an unknown param type * (HtmlComponent.js (97)) Property data has an unknown type * (HtmlComponentMessageEvent.js (16)) Property fileLimit has mismatching types for get (number) and set (string) (UploadButton.js (128, 149)) Operation set has an unknown param type * (window-frontend.js (201)) Operation get has an unknown return type * (window-frontend.js (234)) Operation set has an unknown param type * (window.js (235)) Operation get has an unknown return type * (window.js (269)) Callback ViewChangeOperation is defined two or more times (AppointmentField.js (347), DatePicker.js (472)) Callback ViewChangeOperation has an unknown return type * (AppointmentField.js (347)) Callback ViewChangeEventHandler is defined two or more times (AppointmentField.js (362), DatePicker.js (466)) Callback Validator has an unknown param type * (ValidatableMixin.js (143)) Property value has an unknown type * (ValueMixin.js (62)) Property value has an unknown type * (ValueMixin.js (89))
changes: Service $w.MenuContainer is new issues: Message ViewChangeEventOptions has an unknown property type * (ApppointmentFieldEvent.js (8)) Operation postMessage has an unknown param type * (HtmlComponent.js (97)) Property data has an unknown type * (HtmlComponentMessageEvent.js (16)) Property fileLimit has mismatching types for get (number) and set (string) (UploadButton.js (128, 149)) Operation set has an unknown param type * (window-frontend.js (201)) Operation get has an unknown return type * (window-frontend.js (234)) Operation set has an unknown param type * (window.js (235)) Operation get has an unknown return type * (window.js (269)) Callback ViewChangeOperation is defined two or more times (AppointmentField.js (347), DatePicker.js (472)) Callback ViewChangeOperation has an unknown return type * (AppointmentField.js (347)) Callback ViewChangeEventHandler is defined two or more times (AppointmentField.js (362), DatePicker.js (466)) Callback Validator has an unknown param type * (ValidatableMixin.js (143)) Property value has an unknown type * (ValueMixin.js (62)) Property value has an unknown type * (ValueMixin.js (89))
… issue detected issues: Message ViewChangeEventOptions has an unknown property type * (ApppointmentFieldEvent.js (8)) Operation postMessage has an unknown param type * (HtmlComponent.js (97)) Property data has an unknown type * (HtmlComponentMessageEvent.js (16)) Property fileLimit has mismatching types for get (number) and set (string) (UploadButton.js (128, 149)) Operation set has an unknown param type * (window-frontend.js (201)) Operation get has an unknown return type * (window-frontend.js (234)) Operation set has an unknown param type * (window.js (235)) Operation get has an unknown return type * (window.js (269)) Callback ViewChangeOperation is defined two or more times (AppointmentField.js (347), DatePicker.js (472)) Callback ViewChangeOperation has an unknown return type * (AppointmentField.js (347)) Callback ViewChangeEventHandler is defined two or more times (AppointmentField.js (362), DatePicker.js (466)) Callback Validator has an unknown param type * (ValidatableMixin.js (143)) Property value has an unknown type * (ValueMixin.js (62)) Property value has an unknown type * (ValueMixin.js (89))
changes: Service $w.Menu has changed description Service $w.ExpandableMenu is new issues: Message ViewChangeEventOptions has an unknown property type * (ApppointmentFieldEvent.js (8)) Operation postMessage has an unknown param type * (HtmlComponent.js (97)) Property data has an unknown type * (HtmlComponentMessageEvent.js (16)) Property fileLimit has mismatching types for get (number) and set (string) (UploadButton.js (128, 149)) Operation set has an unknown param type * (window-frontend.js (201)) Operation get has an unknown return type * (window-frontend.js (234)) Operation set has an unknown param type * (window.js (235)) Operation get has an unknown return type * (window.js (269)) Callback ViewChangeOperation is defined two or more times (AppointmentField.js (347), DatePicker.js (472)) Callback ViewChangeOperation has an unknown return type * (AppointmentField.js (347)) Callback ViewChangeEventHandler is defined two or more times (AppointmentField.js (362), DatePicker.js (466)) Callback Validator has an unknown param type * (ValidatableMixin.js (143)) Property value has an unknown type * (ValueMixin.js (62)) Property value has an unknown type * (ValueMixin.js (89))
changes: Service $w.ExpandableMenu has changed description issues: Message ViewChangeEventOptions has an unknown property type * (ApppointmentFieldEvent.js (8)) Operation postMessage has an unknown param type * (HtmlComponent.js (97)) Property data has an unknown type * (HtmlComponentMessageEvent.js (16)) Property fileLimit has mismatching types for get (number) and set (string) (UploadButton.js (128, 149)) Operation set has an unknown param type * (window-frontend.js (201)) Operation get has an unknown return type * (window-frontend.js (234)) Operation set has an unknown param type * (window.js (235)) Operation get has an unknown return type * (window.js (269)) Callback ViewChangeOperation is defined two or more times (AppointmentField.js (347), DatePicker.js (472)) Callback ViewChangeOperation has an unknown return type * (AppointmentField.js (347)) Callback ViewChangeEventHandler is defined two or more times (AppointmentField.js (362), DatePicker.js (466)) Callback Validator has an unknown param type * (ValidatableMixin.js (143)) Property value has an unknown type * (ValueMixin.js (62)) Property value has an unknown type * (ValueMixin.js (89))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.