fix(iOS): implement scaleX and scaleY transition animations.
#7807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oblador
changed the title
oblador
force-pushed
the
ios-scale-transition
branch
from
f540aa1 to
ba2ac34
Compare
|
Not sure about the failing tests, seems unrelated |
oblador
force-pushed
the
ios-scale-transition
branch
from
ba2ac34 to
91b2aba
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Bad bot |
|
@asafkorem Any chance this could get some eyes on it? |
|
Yes @oblador, I'll review it later this week |
asafkorem
changed the title
scaleX and scaleY transition animations.
|
Awesome, thanks for the review! Would you mind delegating another PR that I’ve had open for quite some time? #7809 |
|
Sure @oblador |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was tearing my hair over why I couldn't get scale transitions to work on iOS while they were working fine on Android, and it turns out it was never implemented 😅
This PR adds this implementation.
Fixes #7066