-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added title and subtitle testIds #7866
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks dude! We're planning on follow up on that right after the holidays. I hope it's alright. |
@d4vidi can you take this? |
Yeah I'll take it in this sprint or the next one |
d4vidi
force-pushed
the
added-title-and-subtitle-testids
branch
from
May 22, 2024 10:55
bbbf5b5
to
d1d244b
Compare
This reverts commit f7b7121.
d4vidi
force-pushed
the
added-title-and-subtitle-testids
branch
from
May 22, 2024 20:30
10f1b6a
to
19588ec
Compare
asafkorem
approved these changes
May 26, 2024
@Niryo Released under |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7879 according to the following formula:
Given a test ID
top-bar-id
over a screen's top-bar (specified either in thesetRoot
or screen's options), the following ID's are automatically set:top-bar-id.title
top-bar-id.subtitle