fix(ios): ensure correct initial tab is rendered when onSwitchToTab is set #7922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @asafkorem! any chance you can help me out reviewing this PR? |
|
Hey @ismarbesic, I'll review your PR soon. Thanks! |
asafkorem
approved these changes
Oct 15, 2024
| @@ -521,6 +521,40 @@ - (void)testSetRoot_withBottomTabsAttachModeOnSwitchToTab { | |||
| XCTAssertTrue(_vc2.isViewLoaded); | |||
| } | |||
|
|
|||
| - (void)testSetRoot_withBottomTabsAttachModeOnSwitchToTabWithCustomIndex { | |||
asafkorem
added a commit
that referenced
this pull request
Oct 16, 2024
This fixes the issue mentioned on #7921, #7922 and #7924. Changing the `selectedIndex` will not have any effect before the setup has finished, the original issue was the method `setSelectedIndex` was called immediately when calling to the `super` initializer with a `0` value regardless of the initial `currentTab`. This prevents the loading of the tab from index `0` regardless of the custom initial rendered tab.
asafkorem
added a commit
that referenced
this pull request
Oct 16, 2024
) This fixes the issue mentioned on #7921, #7922 and #7924. Changing the `selectedIndex` will not have any effect before the setup has finished, the original issue was the method `setSelectedIndex` was called immediately when calling to the `super` initializer with a `0` value regardless of the initial `currentTab`. This prevents the loading of the tab from index `0` regardless of the custom initial rendered tab.
|
Released with v7.40.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7921 by setting _currentTabIndex in the RNNBottomTabsController before initialization happens.