Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation to note there are extension changes for oopbas #277

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

robmen
Copy link
Member

@robmen robmen commented Apr 25, 2024

Also add a note that building bundles using wix.exe requires updating to the new WixToolset.BootstrapperApplications.wixext.

Fixes wixtoolset/issues#8155

Also add a note that building bundles using wix.exe requires updating to the new
`WixToolset.BootstrapperApplications.wixext`.

Fixes wixtoolset/issues#8155
@robmen robmen requested a review from barnson April 25, 2024 20:30
@robmen robmen enabled auto-merge (rebase) April 25, 2024 20:30
@robmen robmen merged commit 1babdfa into master Apr 25, 2024
2 checks passed
@robmen robmen deleted the robmen/link-extension-changes branch April 25, 2024 20:42
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2024
@robmen
Copy link
Member Author

robmen commented Apr 25, 2024

Hmm. The auto-merge didn't wait for approval by an assigned reviewer. That's not right.

Copy link
Member

@barnson barnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise lgtm.

@@ -80,7 +80,7 @@ To take advantage of the breaking change, we took the opportunity to improve the
* `WixToolset.BalUtil` - renamed to `WixToolset.BootstrapperApplicationApi` to provide the native headers and libraries to communicate with Burn. Also, split out the `WixToolset.WixStandardBootstrapperApplicationFunctionApi` for WixStdBA BAFunctions API.
* `WixToolset.Mba.Core` - merged the managed libraries into the `WixToolset.BootstrapperApplicationApi` so there is a single package for custom bootstrapper applications.
* `WixToolset.BextUtil` - renamed to `WixToolset.BootstrapperExtensionApi`.
* `WixToolset.Bal.wixext` - renamed to `WixToolset.BootstrapperApplications.wixext` but also kept `WixToolset.Bal.wixext` for backwards compatibility.
* `WixToolset.Bal.wixext` - renamed to `WixToolset.BootstrapperApplications.wixext` but also kept `WixToolset.Bal.wixext` for backwards compatibility with `PackageReferences` in MSBuild. Note: this means that if using `wix.exe` to add extensions you will need to use the new name `WixToolset.BootstrapperApplications.wixext`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PackageReferences in MSBuild.
PackageReferences in MSBuild projects.

Note: this means that if using wix.exe to add extensions you will need to use the new name WixToolset.BootstrapperApplications.wixext.
Note: When using wix.exe, you need to use the new name WixToolset.BootstrapperApplications.wixext.

@@ -199,3 +199,5 @@ For more information, see the [_Default feature_ WIP](https://github.com/wixtool
- WixToolset.Firewall.wixext now supports the capabilities of the modern Windows Firewall. See [the documentation](../schema/firewall/firewallexception.md) for all the new goodness. Thanks to [@chrisbednarski](https://github.com/chrisbednarski) for all [the work](https://github.com/wixtoolset/wix/pulls?q=is%3Apr+author%3Achrisbednarski).
- WixToolset.Netfx.wixext's [DotNetCompatibilityCheck](../schema/netfx/dotnetcompatibilitycheck.md) now sets the specified property to 13 when the requested platform is not compatible with the platform the installer is running on. Thanks to [@apacker1](https://github.com/apacker1) for the [pull request](https://github.com/wixtoolset/wix/pull/459).
- WixToolset.Util.wixext now has the following `_NODOMAIN` properties from [WixQueryOsWellKnownSID](../tools/wixext/wininfo.md#querywindowswellknownsids): `WIX_ACCOUNT_ADMINISTRATORS_NODOMAIN`, `WIX_ACCOUNT_GUESTS_NODOMAIN`, `WIX_ACCOUNT_LOCALSERVICE_NODOMAIN`, `WIX_ACCOUNT_LOCALSYSTEM_NODOMAIN`, `WIX_ACCOUNT_NETWORKSERVICE_NODOMAIN`, and `WIX_ACCOUNT_USERS_NODOMAIN`. Thanks to [@mistoll](https://github.com/mistoll) for the [pull request](https://github.com/wixtoolset/wix/pull/407).

See [Out-of-process bootstrapper applications](/docs/fivefour/oopbas/) for additional extension changes related to building bundles.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

applications](/docs/fivefour/oopbas/)
applications](oopbas.md)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bal extension shows damaged with wix 5
2 participants