Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring the Tado Classes. #128

Conversation

Moritz-Schmidt
Copy link

Description

Refactoring the Tado Classes by creating a common base class. The base class contains all functionality which hasn't changed from the pre Tado X API to Tado X API and enforces compatible typing and naming between versions.
This also reduces duplicated code and improves typing.


Related Issues

Link any related issues that this pull request resolves or is associated with:


Type of Changes

Mark the type of changes included in this pull request:

  • Bugfix
  • New Feature
  • Documentation Update
  • Refactor
  • Other (please specify):

Checklist

  • I have tested the changes locally and they work as expected.
  • I have added/updated necessary documentation (if applicable).
  • I have followed the code style and guidelines of the project.
  • I have searched for and linked any related issues.

@Moritz-Schmidt
Copy link
Author

I think about doing something similar for the Zone classes and have some more Ideas for improvement, I think those Ideas should be discussed first before I put a lot of work in them. I'll open a new discussion for that.

@wmalgadey
Copy link
Owner

@erwindouna I like this change, should we merge it bevor your changes to my_tado.py? It will introduce some merge conflicts in #127 and #124

@wmalgadey wmalgadey self-assigned this Dec 28, 2024
@erwindouna
Copy link
Collaborator

Great work here, @Moritz-Schmidt!
@wmalgadey a rebase needs to take place anyhow. Just need to decide where it will hit. I think it make sense to finish the earlier PR's and then try to rebase this PR.

@wmalgadey wmalgadey force-pushed the seamless-tadox-support branch from 0c7a006 to 6c0a938 Compare December 28, 2024 20:14
@wmalgadey wmalgadey merged commit ea8ef12 into wmalgadey:seamless-tadox-support Dec 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants