Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update facility set link relations in MSC examples #133

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

tomkralidis
Copy link
Contributor

Fixes FacilitySet link relations in ECCC/MSC examples (thanks @antje-s for catching).

@tomkralidis tomkralidis added the bug Something isn't working label Nov 27, 2023
@tomkralidis tomkralidis changed the title Ca eccc msc dcpc update facility set link relations update facility set link relations in MSC examples Nov 27, 2023
@tomkralidis tomkralidis merged commit ef1e828 into main Nov 27, 2023
0 of 6 checks passed
@tomkralidis tomkralidis deleted the ca-eccc-msc-dcpc-update-FacilitySet-link-relations branch November 27, 2023 13:24
Copy link
Member

@amilan17 amilan17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like using this def.wmo.int for URIs and I don't like putting a URI in the "rel" property.

@tomkralidis
Copy link
Contributor Author

We can decide / finalize once we determine where the final artifacts will be located

Using URIs in the rel property is a perfectly valid design, and is used extensively in OGC standards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants