firmware: change the default range for knobs (again)

wntrblm · Feb 19, 2021 · 29d42c6 · 29d42c6
1 parent a8f44e7
commit 29d42c6
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 15 deletions.
diff --git a/factory/libgemini/gem_settings.py b/factory/libgemini/gem_settings.py
@@ -23,14 +23,14 @@ class GemSettings(structy.Struct):
     led_brightness: int = 127
     """The front-plate LED brightness."""
 
-    castor_knob_min: structy.Fix16 = -1.02
-    """Configuration for the CV knob mins and maxs in volts, defaults to -1.02 to +1.10."""
+    castor_knob_min: structy.Fix16 = -1.2
+    """Configuration for the CV knob mins and maxs in volts, defaults to -1.2 to +1.2."""
 
-    castor_knob_max: structy.Fix16 = 1.1
+    castor_knob_max: structy.Fix16 = 1.2
 
-    pollux_knob_min: structy.Fix16 = -1.02
+    pollux_knob_min: structy.Fix16 = -1.2
 
-    pollux_knob_max: structy.Fix16 = 1.1
+    pollux_knob_max: structy.Fix16 = 1.2
 
     chorus_max_intensity: structy.Fix16 = 0.05
     """Maximum amount that the chorus can impact Pollux's frequency."""

diff --git a/firmware/data/gem_settings.structy b/firmware/data/gem_settings.structy
@@ -10,11 +10,11 @@ class GemSettings:
     """The front-plate LED brightness."""
     led_brightness: uint16 = 127
 
-    """Configuration for the CV knob mins and maxs in volts, defaults to -1.02 to +1.10."""
-    castor_knob_min: fix16 = -1.02
-    castor_knob_max: fix16 = 1.10
-    pollux_knob_min: fix16 = -1.02
-    pollux_knob_max: fix16 = 1.10
+    """Configuration for the CV knob mins and maxs in volts, defaults to -1.2 to +1.2."""
+    castor_knob_min: fix16 = -1.2
+    castor_knob_max: fix16 = 1.2
+    pollux_knob_min: fix16 = -1.2
+    pollux_knob_max: fix16 = 1.2
 
     """Maximum amount that the chorus can impact Pollux's frequency."""
     chorus_max_intensity: fix16 = 0.05

diff --git a/firmware/src/generated/gem_settings.c b/firmware/src/generated/gem_settings.c
@@ -11,10 +11,10 @@ void GemSettings_init(struct GemSettings* inst) {
     inst->adc_gain_corr = 2048;
     inst->adc_offset_corr = 0;
     inst->led_brightness = 127;
-    inst->castor_knob_min = F16(-1.02);
-    inst->castor_knob_max = F16(1.1);
-    inst->pollux_knob_min = F16(-1.02);
-    inst->pollux_knob_max = F16(1.1);
+    inst->castor_knob_min = F16(-1.2);
+    inst->castor_knob_max = F16(1.2);
+    inst->pollux_knob_min = F16(-1.2);
+    inst->pollux_knob_max = F16(1.2);
     inst->chorus_max_intensity = F16(0.05);
     inst->lfo_frequency = F16(0.2);
     inst->cv_offset_error = F16(0.0);

diff --git a/firmware/src/generated/gem_settings.h b/firmware/src/generated/gem_settings.h
@@ -18,7 +18,7 @@ struct GemSettings {
     int16_t adc_offset_corr;
     /* The front-plate LED brightness. */
     uint16_t led_brightness;
-    /* Configuration for the CV knob mins and maxs in volts, defaults to -1.02 to +1.10. */
+    /* Configuration for the CV knob mins and maxs in volts, defaults to -1.2 to +1.2. */
     fix16_t castor_knob_min;
     fix16_t castor_knob_max;
     fix16_t pollux_knob_min;