Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update type annotation of stderr parameter to make it optional #835

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Update type annotation of stderr parameter to make it optional #835

merged 1 commit into from
Jun 27, 2024

Conversation

edgarrmondragon
Copy link
Contributor

@edgarrmondragon edgarrmondragon commented Jun 25, 2024 •
edited
Loading

@edgarrmondragon edgarrmondragon marked this pull request as ready for review June 25, 2024 08:44
@edgarrmondragon edgarrmondragon mentioned this pull request Jun 25, 2024
Merged
cjolowicz
cjolowicz approved these changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@cjolowicz cjolowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If you want to get the command output using the silent flag, passing stderr as None prevents mingling stdout and stderr.

@cjolowicz cjolowicz merged commit 4fb39b6 into wntrblm:main Jun 27, 2024
20 checks passed
@edgarrmondragon edgarrmondragon deleted the typing-stderr-optional branch June 28, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjolowicz cjolowicz cjolowicz approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edgarrmondragon @cjolowicz