Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: pulled out get_virtualenv & better typing #882

Merged
merged 1 commit into from
Nov 4, 2024
Merged

refactor: pulled out get_virtualenv & better typing #882

merged 1 commit into from
Nov 4, 2024

Conversation

henryiii
Copy link
Collaborator

Pulled out from #881.

@henryiii
refactor: pulled out get_virtualenv & better typing
eba60bc 
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
DiddiLeija
DiddiLeija approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@DiddiLeija DiddiLeija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@henryiii henryiii merged commit 622458c into wntrblm:main Nov 4, 2024
24 checks passed
@henryiii henryiii deleted the henryiii/refactor/venvtypes branch November 4, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiddiLeija DiddiLeija DiddiLeija approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henryiii @DiddiLeija