Shorten paths and modernize imports #137
Conversation
|
This is already turning out bigger than anticipated 😅 |
|
@ogoffart Do you like it more this way? Looks simple and sparse to me. Very copy-pastable for a reader. It currently lacks my favorite "wrapper around" and links boilerplate, but that's a different topic. |
|
TBH i liked it better before (with the full path in the code). But that's not so important. |
* Most noticeably, shortened std::ffi::CStr[ing] and ::std::os::raw::c_void.
* (qmetaobject/src/scenegraph.rs):
- Removed probably misplaced #[cfg(qt_5.8)] attribute before use super::*;
- Fixed indentation in screnegraph, because cargo fmt could be wrong when
it comes to macros.
ratijas
force-pushed
the
shorten-uses
branch
2 times, most recently
from
f641d1d
to
4c1e8a8
Compare
|
Ahem… So… Not sure it was worth it in case of |
ratijas
changed the title
|
Just a little tiny whitespace nit while I'm at it. Now I consider it done, although I've almost sure missed something. And that's why I'm genuinely uncomfortable with merging it without an approval. There is no rush though. Take your time. |
|
One week was just about enough, I think. Gotta review myself and merge it tomorrow, if no concerns will be raised in the process or by that time. |
Replaces all `extern crate ...` and especially #[macro_use] statements
with direct `use`s of relevant items.
Introduces cstr! crate & macro to examples, because we don't want our dear
users/readers to suffer with raw CStr nightmare:
std::ffi::CStr::from_bytes_with_nul(b"...\0").unwrap()
|
Shortened more paths, especially in tests. Removed some strange std stuff, such as |
|
CI is freaking out. Retrying. |
|
Done and done. Now, back to QVariant and QMetaType at #136. |
ratijas
added
A-docs
Most noticeably, std::ffi::CStr[ing] and ::std::os::raw::c_void.
Just a clean-up, because I needed QMetaType in a good shape.
The more I play with QVariant implementations, the more I think QMetaType belongs to qttypes crate. I can not justify that they are not split in different packages.