Impl From<QString>, From<QByteArray> for Vec<u8> #261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogoffart
reviewed
Mar 13, 2022
qttypes/src/qtcore/qstring.rs
Outdated
| @@ -317,6 +317,12 @@ impl TryFrom<QString> for i16 { | |||
| } | |||
| } | |||
|
|
|||
| impl From<QString> for Vec<u8> { | |||
| fn from(x: QString) -> Self { | |||
| QByteArray::from(x).into() | |||
There was a problem hiding this comment.
First you convert from QString to QByteArray, and then again to to Vec, that's two allocation.
You'd be better of using Rust's DecodeUtf16
(or passing through String instead)
|
I see, I will check out a better way to achieve this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I basically needed implementation of
Into<Vec<u8>>so that I can constructCString::new()fromQString.I am not sure whether this is the best way to achieve this so I would like someone else's input on this.