-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature "qtwidgets" added. #294
base: master
Are you sure you want to change the base?
Conversation
Link with QtWidgets and use QApplication when activated (default) Use QGuiApplication when not.
This is a breaking change so it will require a major version update. |
major as in 1.0.0 or as 0.3.0 ? Any idea on implementing this without making it a breaking change ? |
0.3 Could happen soon. |
nah, it's not like I'm actively working with anything in Rust lately. But thanks for asking! Maybe we could consider finilizing and merging #227 as well? |
Since this PR seems to be replacing #211, how about adding a little note to README just like they did? |
Also, this
|
README entry added, my PR is almost identical to #211 |
Link with QtWidgets and use QApplication when activated (default) Use QGuiApplication when not.
Replaces #288
I rewrote the patch in a new clean branch, keeping the master for my own projects dependency.
As #[cfg] and cpp! does not work well (if not at all together), I used a C++ predefined symbol to configure the used class.
Not as clean as I would like but I lost too much time already to figure out somthing that works.
Tell me if you have a better solution.