feat(DMA): implement DMA sniffing (partially) #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements (parts of) the RP2040 datasheet, chapter 2.5.5.2. Currently, the code disobeys some settings in SNIFF_CTRL. It just assumes OUT_INV = OUT_REV = SNIFF_BSWAP = 0; CALC = 0xf. I.e., it can only do simple summation, no further checksumming.
|
Thanks! Would it be hard to support OUT_INV, OUT_REV, and SNIFF_BSWAP as well? For the bit reversal part, we already have an implementation. You could move it to |
|
Nah, not hard at all. Will look into it when I have some more time |
urish
reviewed
Jan 8, 2022
|
Guess you are busy nowadays? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements (parts of) the RP2040 datasheet, chapter 2.5.5.2.
Currently, the code disobeys some settings in SNIFF_CTRL.
It just assumes OUT_INV = OUT_REV = SNIFF_BSWAP = 0; CALC = 0xf.
I.e., it can only do simple summation, no further checksumming.
Is the style OK? Would you be willing to merge this without the features mentioned above? I'm not really in the mood to add the other checksumming options...
Tested with a transfer size of 16 bits using the code you already know from #90 ;)
Just with the commented-out parts of RP2040ADC.py enabled. So you can easily test this in https://wokwi.com/arduino/projects/320232834674459219