Simulator fixes and support for using MacOS:

* Added simulator support for Mac. * Fix for simulator to properly assemble wolfboot.bin + signedtestapp + update + swap. * Fixes for handling 64-bit assigned mmap virtual addresses. Added hal_flash_write and hal_flash_erase support for 64-bit address using uintptr_t. Enabled if platform is 64-bit and `FORCE_32BIT` is not defined * Fix simulator conflict with src/libwolfboot.o object in test-app. * Cleanup test-app linker flags.
wolfSSL · Aug 3, 2023 · 215bbcd · 215bbcd
1 parent 7638bfb
commit 215bbcd
Show file tree

Hide file tree

Showing 33 changed files with 335 additions and 179 deletions.
diff --git a/.gitignore b/.gitignore
@@ -93,6 +93,7 @@ include/target.h
 .bootloader-partition-size
 
 # Test tools
+tools/check_config/check_config
 tools/test-expect-version/test-expect-version
 tools/test-update-server/server
 tools/uart-flash-server/ufserver

diff --git a/Makefile b/Makefile
@@ -175,12 +175,14 @@ test-app/image.elf: wolfboot.elf
 	$(Q)$(MAKE) -C test-app WOLFBOOT_ROOT="$(WOLFBOOT_ROOT)" image.elf
 	$(Q)$(SIZE) test-app/image.elf
 
-internal_flash.dd: $(BINASSEMBLE) wolfboot.elf test-app/image_v1_signed.bin
+internal_flash.dd: $(BINASSEMBLE) wolfboot.bin $(BOOT_IMG) $(PRIVATE_KEY) test-app/image_v1_signed.bin
 	@echo "\t[MERGE] internal_flash.dd"
 	$(Q)dd if=/dev/zero bs=1 count=$$(($(WOLFBOOT_SECTOR_SIZE))) > /tmp/swap
-	$(Q)$(BINASSEMBLE) $@ 0 test-app/image_v1_signed.bin \
-		$(WOLFBOOT_PARTITION_SIZE) /tmp/swap \
-		$$(($(WOLFBOOT_PARTITION_SIZE)*2)) /tmp/swap
+	$(Q)$(BINASSEMBLE) $@ \
+		0 wolfboot.bin \
+		$$(($(WOLFBOOT_PARTITION_BOOT_ADDRESS) - $(ARCH_FLASH_OFFSET))) test-app/image_v1_signed.bin \
+		$$(($(WOLFBOOT_PARTITION_UPDATE_ADDRESS)-$(ARCH_FLASH_OFFSET))) /tmp/swap \
+		$$(($(WOLFBOOT_PARTITION_SWAP_ADDRESS)-$(ARCH_FLASH_OFFSET))) /tmp/swap
 
 factory.bin: $(BINASSEMBLE) wolfboot.bin $(BOOT_IMG) $(PRIVATE_KEY) test-app/image_v1_signed.bin
 	@echo "\t[MERGE] $@"

diff --git a/arch.mk b/arch.mk
@@ -451,7 +451,7 @@ ifeq ($(USE_GCC),1)
   CC=$(CROSS_COMPILE)gcc
   LD=$(CROSS_COMPILE)gcc
   AS=$(CROSS_COMPILE)gcc
-  OBJCOPY=$(CROSS_COMPILE)objcopy
+  OBJCOPY?=$(CROSS_COMPILE)objcopy
   SIZE=$(CROSS_COMPILE)size
   OUTPUT_FLAG=-o
 endif
@@ -569,7 +569,6 @@ ifeq ($(TARGET),x86_64_efi)
 endif
 
 ifeq ($(TARGET),sim)
-  ARCH_FLASH_OFFSET=0xC0000000
   USE_GCC_HEADLESS=0
   LD = gcc
   UPDATE_OBJS:=src/update_flash.o

diff --git a/config/examples/sim-delta-update.config b/config/examples/sim-delta-update.config
@@ -6,12 +6,14 @@ WOLFBOOT_SMALL_STACK=1
 SPI_FLASH=0
 DEBUG=1
 DELTA_UPDATES=1
-# it should be multiple of system page size
+
+# sizes should be multiple of system page size
 WOLFBOOT_PARTITION_SIZE=0x40000
 WOLFBOOT_SECTOR_SIZE=0x1000
-WOLFBOOT_PARTITION_BOOT_ADDRESS=0xC0020000
+WOLFBOOT_PARTITION_BOOT_ADDRESS=0x20000
 # if on external flash, it should be multiple of system page size
-WOLFBOOT_PARTITION_UPDATE_ADDRESS=0xC0060000
-WOLFBOOT_PARTITION_SWAP_ADDRESS=0xC00A0000
+WOLFBOOT_PARTITION_UPDATE_ADDRESS=0x60000
+WOLFBOOT_PARTITION_SWAP_ADDRESS=0xA0000
+
 # required for keytools
 WOLFBOOT_FIXED_PARTITIONS=1
diff --git a/config/examples/sim-ecc.config b/config/examples/sim-ecc.config
@@ -5,12 +5,14 @@ HASH?=SHA256
 WOLFBOOT_SMALL_STACK=1
 SPI_FLASH=0
 DEBUG=1
-# it should be multiple of system page size
+
+# sizes should be multiple of system page size
 WOLFBOOT_PARTITION_SIZE=0x40000
 WOLFBOOT_SECTOR_SIZE=0x1000
-WOLFBOOT_PARTITION_BOOT_ADDRESS=0xC0020000
+WOLFBOOT_PARTITION_BOOT_ADDRESS=0x20000
 # if on external flash, it should be multiple of system page size
-WOLFBOOT_PARTITION_UPDATE_ADDRESS=0xC0060000
-WOLFBOOT_PARTITION_SWAP_ADDRESS=0xC00A0000
+WOLFBOOT_PARTITION_UPDATE_ADDRESS=0x60000
+WOLFBOOT_PARTITION_SWAP_ADDRESS=0xA0000
+
 # required for keytools
 WOLFBOOT_FIXED_PARTITIONS=1
diff --git a/config/examples/sim-encrypt-delta-update.config b/config/examples/sim-encrypt-delta-update.config
@@ -9,12 +9,14 @@ ENCRYPT=1
 ENCRYPT_WITH_AES128=1
 DEBUG=1
 DELTA_UPDATES=1
-# it should be multiple of system page size
+
+# sizes should be multiple of system page size
 WOLFBOOT_PARTITION_SIZE=0x40000
 WOLFBOOT_SECTOR_SIZE=0x1000
-WOLFBOOT_PARTITION_BOOT_ADDRESS=0xC0020000
+WOLFBOOT_PARTITION_BOOT_ADDRESS=0x20000
 # if on external flash, it should be multiple of system page size
 WOLFBOOT_PARTITION_UPDATE_ADDRESS=0x00000
 WOLFBOOT_PARTITION_SWAP_ADDRESS=0x40000
+
 # required for keytools
 WOLFBOOT_FIXED_PARTITIONS=1
diff --git a/config/examples/sim-encrypt-update.config b/config/examples/sim-encrypt-update.config
@@ -8,12 +8,14 @@ EXT_FLASH=1
 ENCRYPT=1
 ENCRYPT_WITH_AES128=1
 DEBUG=1
-# it should be multiple of system page size
+
+# sizes should be multiple of system page size
 WOLFBOOT_PARTITION_SIZE=0x40000
 WOLFBOOT_SECTOR_SIZE=0x1000
-WOLFBOOT_PARTITION_BOOT_ADDRESS=0xC0020000
+WOLFBOOT_PARTITION_BOOT_ADDRESS=0x20000
 # if on external flash, it should be multiple of system page size
 WOLFBOOT_PARTITION_UPDATE_ADDRESS=0x00000
 WOLFBOOT_PARTITION_SWAP_ADDRESS=0x40000
+
 # required for keytools
 WOLFBOOT_FIXED_PARTITIONS=1
diff --git a/config/examples/sim-nvm-writeonce.config b/config/examples/sim-nvm-writeonce.config
@@ -5,13 +5,15 @@ HASH?=SHA256
 WOLFBOOT_SMALL_STACK=1
 SPI_FLASH=0
 DEBUG=1
-# it should be multiple of system page size
 NVM_FLASH_WRITEONCE=1
+
+# sizes should be multiple of system page size
 WOLFBOOT_PARTITION_SIZE=0x40000
 WOLFBOOT_SECTOR_SIZE=0x1000
-WOLFBOOT_PARTITION_BOOT_ADDRESS=0xC0020000
+WOLFBOOT_PARTITION_BOOT_ADDRESS=0x20000
 # if on external flash, it should be multiple of system page size
-WOLFBOOT_PARTITION_UPDATE_ADDRESS=0xC0060000
-WOLFBOOT_PARTITION_SWAP_ADDRESS=0xC00A0000
+WOLFBOOT_PARTITION_UPDATE_ADDRESS=0x60000
+WOLFBOOT_PARTITION_SWAP_ADDRESS=0xA0000
+
 # required for keytools
 WOLFBOOT_FIXED_PARTITIONS=1
diff --git a/config/examples/sim-rsa.config b/config/examples/sim-rsa.config
@@ -6,12 +6,14 @@ WOLFBOOT_SMALL_STACK=1
 SPI_FLASH=0
 DEBUG=1
 SPMATHALL=1
-# it should be multiple of system page size
+
+# sizes should be multiple of system page size
 WOLFBOOT_PARTITION_SIZE=0x40000
 WOLFBOOT_SECTOR_SIZE=0x1000
-WOLFBOOT_PARTITION_BOOT_ADDRESS=0xC0020000
+WOLFBOOT_PARTITION_BOOT_ADDRESS=0x20000
 # if on external flash, it should be multiple of system page size
-WOLFBOOT_PARTITION_UPDATE_ADDRESS=0xC0060000
-WOLFBOOT_PARTITION_SWAP_ADDRESS=0xC00A0000
+WOLFBOOT_PARTITION_UPDATE_ADDRESS=0x60000
+WOLFBOOT_PARTITION_SWAP_ADDRESS=0xA0000
+
 # required for keytools
 WOLFBOOT_FIXED_PARTITIONS=1
diff --git a/config/examples/sim-tpm.config b/config/examples/sim-tpm.config
@@ -0,0 +1,23 @@
+ARCH=sim
+TARGET=sim
+SIGN?=RSA2048
+HASH?=SHA256
+WOLFBOOT_SMALL_STACK=1
+SPI_FLASH=0
+DEBUG=1
+SIM_TPM=1
+WOLFTPM=1
+
+# sizes should be multiple of system page size
+WOLFBOOT_PARTITION_SIZE=0x40000
+WOLFBOOT_SECTOR_SIZE=0x1000
+WOLFBOOT_PARTITION_BOOT_ADDRESS=0x80000
+# if on external flash, it should be multiple of system page size
+WOLFBOOT_PARTITION_UPDATE_ADDRESS=0x100000
+WOLFBOOT_PARTITION_SWAP_ADDRESS=0x180000
+
+# required for keytools
+WOLFBOOT_FIXED_PARTITIONS=1
+
+# TPM Logging
+# CFLAGS_EXTRA+=-DDEBUG_WOLFTPM -DWOLFTPM_DEBUG_VERBOSE
diff --git a/config/examples/sim.config b/config/examples/sim.config
@@ -5,12 +5,14 @@ HASH?=SHA256
 WOLFBOOT_SMALL_STACK=1
 SPI_FLASH=0
 DEBUG=1
-# it should be multiple of system page size
+
+# sizes should be multiple of system page size
 WOLFBOOT_PARTITION_SIZE=0x40000
 WOLFBOOT_SECTOR_SIZE=0x1000
-WOLFBOOT_PARTITION_BOOT_ADDRESS=0xC0020000
+WOLFBOOT_PARTITION_BOOT_ADDRESS=0x20000
 # if on external flash, it should be multiple of system page size
-WOLFBOOT_PARTITION_UPDATE_ADDRESS=0xC0060000
-WOLFBOOT_PARTITION_SWAP_ADDRESS=0xC00A0000
+WOLFBOOT_PARTITION_UPDATE_ADDRESS=0x60000
+WOLFBOOT_PARTITION_SWAP_ADDRESS=0xA0000
+
 # required for keytools
 WOLFBOOT_FIXED_PARTITIONS=1
diff --git a/docs/Targets.md b/docs/Targets.md
@@ -1515,6 +1515,10 @@ make test-sim-internal-flash-with-update
 # it should print 2
 ./wolfboot.elf success get_version
 ```
+
+Note: This also works on Mac OS, but `objcopy` does not exist. Install with `brew install binutils` and make using `OBJCOPY=/usr/local/Cellar//binutils/2.41/bin/objcopy make`.
+
+
 ## renesas-rx72n
 
 This example for `Renesas RX72N` demonstrates simple secure firmware update by wolfBoot. A sample application v1 is

diff --git a/hal/nxp_t2080.c b/hal/nxp_t2080.c
@@ -532,7 +532,7 @@ void hal_init(void)
 #endif
 }
 
-int hal_flash_write(uint32_t address, const uint8_t *data, int len)
+int hal_flash_write(uintptr_t address, const uint8_t *data, int len)
 {
     (void)address;
     (void)data;
@@ -541,7 +541,7 @@ int hal_flash_write(uint32_t address, const uint8_t *data, int len)
     return 0;
 }
 
-int hal_flash_erase(uint32_t address, int len)
+int hal_flash_erase(uintptr_t address, int len)
 {
     (void)address;
     (void)len;

diff --git a/hal/raspi3.c b/hal/raspi3.c
@@ -114,7 +114,7 @@ void hal_prepare_boot(void)
 }
 
 
-int RAMFUNCTION hal_flash_write(uint32_t address, const uint8_t *data, int len)
+int RAMFUNCTION hal_flash_write(uintptr_t address, const uint8_t *data, int len)
 {
     return 0;
 }
@@ -128,7 +128,7 @@ void RAMFUNCTION hal_flash_lock(void)
 }
 
 
-int RAMFUNCTION hal_flash_erase(uint32_t address, int len)
+int RAMFUNCTION hal_flash_erase(uintptr_t address, int len)
 {
     return 0;
 }