-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add hal_init to the imx test-app and trigger update #352
Conversation
test-app/app_imx_rt.c
Outdated
@@ -124,6 +124,12 @@ void rt1050_init_pins(void) | |||
|
|||
void main(void) | |||
{ | |||
hal_init(); | |||
if (wolfBoot_current_firmware_version() == 1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please move this down after:
PRINTF("wolfBoot Test app, version = %d\r\n",
wolfBoot_current_firmware_version());
test-app/app_imx_rt.c
Outdated
@@ -124,6 +124,12 @@ void rt1050_init_pins(void) | |||
|
|||
void main(void) | |||
{ | |||
hal_init(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[CC-ARM] app_imx_rt.o
app_imx_rt.c: In function 'main':
app_imx_rt.c:127:5: warning: implicit declaration of function 'hal_init' [-Wimplicit-function-declaration]
127 | hal_init();
| ^~~~~~~~```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it actually wasn't calling hal_init
that was required, I needed to move the wolfBoot_update_trigger
to before the SysTick_Config call, it seems to mess with hal_flash_write
test-app/app_imx_rt.c
Outdated
#endif | ||
if (wolfBoot_current_firmware_version() == 1) { | ||
wolfBoot_update_trigger(); | ||
return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check indent
test-app/app_imx_rt.c
Outdated
return; | ||
} | ||
|
||
SysTick_Config(SystemCoreClock / 1000U); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the SysTick is causing the issue please add a code comment here. See if it works without it or if it is actually needed for the delay. Can init_debug_console
still be moved up, is it really required to be in the example? Does the PRINTF("wolfBoot Test app
still work?
it seems SysTick isn't required and the print statements still work without it, I've removed it and cleaned up the test-app |
ZD 16472