Add Raspberry Pi3 Uart #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielinux
reviewed
Aug 26, 2024
hal/raspi3.c
Outdated
| } while(*UART0_FR & 0x10); | ||
| /* read it and return */ | ||
| c = (char)(*UART0_DR); | ||
| /* convert carrige return to newline */ |
There was a problem hiding this comment.
spelling: carriage. Is this conversion really required?
danielinux
reviewed
Aug 26, 2024
hal/raspi3.c
Outdated
| uint32_t len = sz; | ||
|
|
||
| while (len > 0 && *buf) { | ||
| /* convert newline to carrige return + newline */ |
There was a problem hiding this comment.
spelling, plus conversion from CR to CR+LF, that should be handled by the caller, or left as is.
There was a problem hiding this comment.
Thanks. Agree. Carriage return code should be handled by the caller.
danielinux
requested changes
Aug 26, 2024
danielinux
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add use case on Raspberry Pi 3 B+ HW