-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wolfcrypt ML-DSA (dilithium) support. #507
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested OK against wolfssl bf29b686
Please do:
- update wolfSSL submodule to master
- add simulator tests
re: simulator tests It looks like we don't have those tests for LMS/XMSS either. Can we perhaps extend |
I'll add them all. It will be good to have sim coverage for all PQ as well! |
Can reproduce one of the failures locally. Seems to be from introduction of USE_WOLF_STRDUP over summer. |
Description
Adds wolfcrypt ML-DSA (wolfcrypt/src/dilithium.c) support to wolfBoot.
Also covers some missing testing for sim target with PQ.
Config
Added sim ML-DSA example:
Use
ML_DSA_LEVEL=<num>
to configure the ML-DSA parameter set. See the config example and updated PQ docs for explanation of parameters.Docs
Updated
docs/PQ.md
to describe ML-DSA and all three NIST approved PQ sig algs we have implemented.Testing
tools/scripts/sim-pq-sunnyday-update.sh
. This is to simplify sim-PQ sunnyday tests..github/workflows/test-sunnyday-simulator.yml
.Prereqs
Requires this PR to build:
Requires this PR to conform to FIPS 204:
Requires these PRs to update lib/wolfssl submodule to master: