Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools renode: reset SIGN_ARGS. #516

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Conversation

philljj
Copy link
Contributor

@philljj philljj commented Oct 30, 2024

Description

SIGN_ARGS is getting duplicate args.

Testing

$./silly_reproducer 
Building key tools
make[1]: Entering directory '/home/jordan/work/boot/src/tools/keytools'
Building signing tool
Building keygen tool
make[1]: Leaving directory '/home/jordan/work/boot/src/tools/keytools'
/home/jordan/work/boot/src/tools/keytools/sign --ml_dsa --sha256 --ml_dsa --sha256  \
$cat silly_reproducer 
#!/bin/bash
# Any of these will do it:
#  cp config/examples/sim.config .config || exit 1
#  cp config/examples/sim-lms.config .config || exit 1
cp config/examples/sim-ml-dsa.config .config || exit 1
make distclean && make clean
make keytools || exit 1
make test-sim-internal-flash-with-update V=1 2>&1 | grep "sign.*sha256.*sha256"

@philljj philljj self-assigned this Oct 30, 2024
@danielinux danielinux merged commit c4f87c6 into wolfSSL:master Oct 30, 2024
99 checks passed
@philljj philljj deleted the fix_dup_sign_args branch October 30, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants