properly unlock flash on re-entry of wolfBoot_swap_and_final_erase #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and move it out of the lock logic of update and delta update
jpbland1
force-pushed
the
reentrant-flash-lock
branch
from
1dfa519 to
bbdf14e
Compare
add hal_flash_unlock after setting the key since setting the key locks flash
|
added hal and ext flash locks to the simulator, fixed test failures caused by flash being accessed while locked. @danielinux any idea why the unit test is failing? is it because I added the locks to hal/sim.c and it's not aware of them? |
|
The hal_flash_lock/unlock functions are mocked and checked, it seems that the unit test is dectecting a |
|
I figured out the issue, it was only unlocking flash when encryption was on, I think it was a copy and paste issue. should be good to go now |
danielinux
requested changes
Dec 17, 2024
danielinux
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and move it out of the lock logic of update and delta update