Using Decode Raw RSA Private Key #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ejohnstown
commented
Jun 1, 2024
•
ejohnstown
commented
- Add a check for wc_RsaPrivateKeyDecodeRaw() to configure.
- If wc_RsaPrivateKeyDecodeRaw() is available (from PR Import Raw RSA Private Key wolfssl#7608), use it to load the private key from GetOpenSshKeyRsa(). If unavailable, process the key the original way.
dgarske
previously approved these changes
Jun 2, 2024
This comment was marked as outdated.
This comment was marked as outdated.
dgarske
requested changes
Jun 3, 2024
src/internal.c
Outdated
|
|
||
| #else /* HAVE_WC_RSAPRIVATEKEYDECODERAW */ | ||
|
|
||
| #include <wolfssl/wolfcrypt/integer.h> |
There was a problem hiding this comment.
You can just include <wolfssl/wolfcrypt/wolfmath.h> now to handle all cases. Its possible integer.h (heap math) could be removed.
src/internal.c
Outdated
| @@ -1353,6 +1352,46 @@ int IdentifyAsn1Key(const byte* in, word32 inSz, int isPrivate, void* heap) | |||
|
|
|||
|
|
|||
| #ifndef WOLFSSH_NO_RSA | |||
|
|
|||
| #ifdef HAVE_WC_RSAPRIVATEKEYDECODERAW | |||
There was a problem hiding this comment.
This is not a portable way to detect this... meaning someone not using configure won't detect or use this new API. But its probably still the best option for now.
There was a problem hiding this comment.
Switched this to checking that wolfSSL is greater than v5.7.0. The new function isn't available in v5.7.0.
4 tasks
1. If wc_RsaPrivateKeyDecodeRaw() is available, use it to load the private key from GetOpenSshKeyRsa(). If unavailable, process the key the original way. 2. Check for wolfSSL version and if greater than v5.7.0, the new function is available. 3. When loading an OpenSSH format RSA key, if wolfSSL's RSA_LOW_MEM is set, skip the u value, and do not calculate dP and dQ. 4. Rename RsaCalcInverses() to RsaCalcDX().
dgarske
approved these changes
Jun 3, 2024
jefferyq2
pushed a commit
to jefferyq2/wolfssh
that referenced
this pull request
Sep 24, 2024
Using Decode Raw RSA Private Key
jefferyq2
pushed a commit
to jefferyq2/wolfssh
that referenced
this pull request
Oct 18, 2024
Using Decode Raw RSA Private Key
jefferyq2
pushed a commit
to jefferyq2/wolfssh
that referenced
this pull request
Oct 29, 2024
Using Decode Raw RSA Private Key
jefferyq2
pushed a commit
to jefferyq2/wolfssh
that referenced
this pull request
Oct 29, 2024
Using Decode Raw RSA Private Key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.