Skip to content

Commit

Permalink
Dilithium: fixes
Browse files Browse the repository at this point in the history
Fix inclusion of functions dilithium_vec_check_low() in build:
--enable-dilithium=verify-only,44,65,87
CFLAGS=-DWOLFSSL_DILITHIUM_VERIFY_SMALL_MEM
Fix memory leaks in unit.test:
--enable-dilithium CFLAGS=-DWC_DILITHIUM_CACHE_MATRIX_A 'CC=clang
-fsanitize=address'
  • Loading branch information
SparkiDev committed Jul 8, 2024
1 parent 595e71d commit d1e26b4
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 2 additions & 0 deletions tests/api.c
Original file line number Diff line number Diff line change
Expand Up @@ -34565,6 +34565,7 @@ static int test_wc_dilithium_make_key_from_seed(void)
ExpectIntEQ(XMEMCMP(key->k, sk_87, sizeof(sk_87)), 0);
#endif

wc_dilithium_free(key);
XFREE(key, NULL, DYNAMIC_TYPE_TMP_BUFFER);
#endif
return EXPECT_RESULT();
Expand Down Expand Up @@ -36710,6 +36711,7 @@ static int test_wc_dilithium_verify_kats(void)
ExpectIntEQ(res, 1);
#endif

wc_dilithium_free(key);
XFREE(key, NULL, DYNAMIC_TYPE_TMP_BUFFER);
#endif
return EXPECT_RESULT();
Expand Down
3 changes: 1 addition & 2 deletions wolfcrypt/src/dilithium.c
Original file line number Diff line number Diff line change
Expand Up @@ -2825,8 +2825,7 @@ static int dilithium_check_low(const sword32* a, sword32 hi)
return ret;
}

#if (!defined(WOLFSSL_DILITHIUM_NO_VERIFY) && \
!defined(WOLFSSL_DILITHIUM_VERIFY_SMALL_MEM)) || \
#if !defined(WOLFSSL_DILITHIUM_NO_VERIFY) || \
(!defined(WOLFSSL_DILITHIUM_NO_SIGN) && \
!defined(WOLFSSL_DILITHIUM_SIGN_SMALL_MEM))
/* Check that the values of the vector are in range.
Expand Down

0 comments on commit d1e26b4

Please sign in to comment.