Improve subjectAltName extension parsing and printing #6525
Conversation
lealem47
force-pushed
the
san
branch
2 times, most recently
from
177f881
to
8ed05f4
Compare
|
Please add adjustments to our python port test with this new support. |
wolfssl/wolfcrypt/asn.h
Outdated
| @@ -2161,7 +2169,7 @@ WOLFSSL_LOCAL int GetInt(mp_int* mpi, const byte* input, word32* inOutIdx, | |||
| word32 maxIdx); | |||
|
|
|||
| #ifdef HAVE_OID_ENCODING | |||
| WOLFSSL_LOCAL int EncodeObjectId(const word16* in, word32 inSz, | |||
| WOLFSSL_API int EncodeObjectId(const word16* in, word32 inSz, | |||
There was a problem hiding this comment.
We may not need WOLFSSL_API here?
There was a problem hiding this comment.
Had to leverage it in wolfCLU
There was a problem hiding this comment.
Lets make a new facing API something like wolfSSL_EncodeObjectId (maybe not that exactly, but having either the wolfSSL_ or wc_ naming convention since public). Sanity checks on the input arguments needs reviewed once opening it up as a public facing API. This also reminds me that although in most cases people are updating wolfCLU and wolfSSL at the same time that is not always the case. Please check that wolfCLU will link to at lease a version older of wolfSSL after the changes.
There was a problem hiding this comment.
Added as a public api. Working on wolfCLU next
|
It looks like --enable-asn=original does not show the registered ID? For older versions of wolfSSL not defaulting to asn template we need the support in asn=original also. |
|
@JacobBarthelmeh the asn=original case should now be covered. Actively working on updating the python port test |
lealem47
assigned JacobBarthelmeh and lealem47 and unassigned lealem47 and JacobBarthelmeh
|
Retest this please Jenkins |
|
Retest this please |
Description
Printing and parsing unstructured name and registeredID attributes.
Parsii
Fixes zd16305
Testing
Customer provided test case with wolfCLU
Checklist