Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Refactor HAVE_PTHREAD and _POSIX_THREADS" #6546

Closed
wants to merge 1 commit into from
Closed

Revert "Refactor HAVE_PTHREAD and _POSIX_THREADS" #6546

wants to merge 1 commit into from

Conversation

dgarske
Copy link
Contributor

@dgarske dgarske commented Jun 27, 2023

Reverts #6536

@dgarske dgarske self-assigned this Jun 27, 2023
@dgarske
Copy link
Contributor Author

dgarske commented Jun 27, 2023

There are too many downstream issues with this refactor, so reverting it for now.

@dgarske
Copy link
Contributor Author

dgarske commented Jun 27, 2023

Looks like the "Windows FIPS Create Package" won't work with the upstream branch. Please ignore that failure.

Cloning into 'wolfssl'...
fatal: couldn't find remote ref revert-6536-pthread_gate

@dgarske dgarske assigned JacobBarthelmeh and unassigned dgarske Jun 27, 2023
@dgarske
Copy link
Contributor Author

dgarske commented Jun 27, 2023

Closing in favor of #6549

@dgarske dgarske closed this Jun 27, 2023
@gojimmypi
Copy link
Contributor

I believe #6549 should fix the problem without doing this full revert.

@dgarske dgarske deleted the revert-6536-pthread_gate branch June 27, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobBarthelmeh JacobBarthelmeh Awaiting requested review from JacobBarthelmeh

Assignees

@JacobBarthelmeh JacobBarthelmeh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgarske @gojimmypi @JacobBarthelmeh