Fixes for WOLFSSL_X509 cert gen, WOLFSSL_ALT_NAMES to --enable-jni #6585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cconlon
force-pushed
the
x509Ext
branch
2 times, most recently
from
f242080
to
9c79df7
Compare
JacobBarthelmeh
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR accompanies work being done in wolfSSL JNI/JSSE for certificate generation. wolfSSL JNI is using the
WOLFSSL_X509APIs for cert gen, where these fixes were needed along the way to assist in setting of key usage, extended key usage, and basic constraints.This PR also modifies the
--enable-jnibuild option to defineWOLFSSL_ALT_NAMES, which is needed for cert generation wrapper support.Testing
Tested through wolfSSL JNI/JSSE. Also added some test cases to
api.cfor setting/getting X509 keyUsage and extendedKeyUsage.Checklist