Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for SP math only case to ensure fast math and heap math are disabled #6590

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

dgarske
Copy link
Contributor

@dgarske dgarske commented Jul 10, 2023

Description

Fixes ZD 16419 and 16415

Testing

./configure --enable-sp-math CFLAGS="-DUSE_FAST_MATH" && make
./configure --enable-sp-math-all CFLAGS="-DUSE_FAST_MATH" && make

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@dgarske dgarske self-assigned this Jul 10, 2023
@dgarske
Copy link
Contributor Author

dgarske commented Jul 10, 2023

Can also reproduce with simply: ./configure --enable-sp-math CFLAGS="-DUSE_FAST_MATH" && make

@dgarske dgarske requested a review from embhorn July 10, 2023 21:09
@dgarske dgarske requested a review from SparkiDev July 10, 2023 21:46
@dgarske dgarske removed their assignment Jul 10, 2023
@SparkiDev
Copy link
Contributor

./configure --enable-sp-math-all CFLAGS="-DUSE_FAST_MATH" && make
Please fix this as well.

@SparkiDev SparkiDev assigned dgarske and unassigned SparkiDev Jul 10, 2023
…led. Also fix build error for case where `WOLFSSL_HAVE_SP_ECC` is defined, but `HAVE_ECC` is not. ZD 16419
@dgarske dgarske requested review from SparkiDev and removed request for SparkiDev and embhorn July 10, 2023 22:13
@dgarske dgarske removed their assignment Jul 10, 2023
@SparkiDev SparkiDev merged commit 9f61cb9 into wolfSSL:master Jul 11, 2023
@dgarske dgarske deleted the sp_math_only branch December 19, 2023 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants