TLSX_CA_Names_Parse: Verify the length of the extension #6644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julek-wolfssl
force-pushed
the
zd/16441
branch
2 times, most recently
from
fd5d5b6
to
c721a98
Compare
JacobBarthelmeh
requested changes
Jul 28, 2023
src/tls.c
Outdated
| if (ret == 0 && wolfSSL_sk_X509_NAME_push(ssl->client_ca_names, name) | ||
| == WOLFSSL_FAILURE) | ||
| if (wolfSSL_sk_X509_NAME_push(ssl->client_ca_names, name) | ||
| == WOLFSSL_FAILURE) | ||
| ret = MEMORY_ERROR; |
There was a problem hiding this comment.
indent this line please since in an inner if statement now
|
retest this please Jenkins |
JacobBarthelmeh
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on #6635 for the memio refactor.