Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CMakeLists.txt file #6645

Closed
wants to merge 1 commit into from
Closed

Fix CMakeLists.txt file #6645

wants to merge 1 commit into from

Conversation

topazus
Copy link

@topazus topazus commented Jul 24, 2023

Description

Please describe the scope of the fix or feature addition.

  • fix the install destination of the library
  • enable tests with CTest
  • fix pkgconfig file

Testing

How did you test?

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

- fix the install destination of the library
- enable tests with CTest
- fix pkgconfig file
@wolfSSL-Bot
Copy link

Can one of the admins verify this patch?

@dgarske dgarske self-assigned this Jul 24, 2023
@dgarske
Copy link
Contributor

dgarske commented Jul 24, 2023

Hi Felix,

Thank you for this contribution. In order to accept this we need to have a signed contributor agreement on file. Please send an email to support @ wolfssl.com referencing this pull request. It would be wonderful to hear more about your project and where you are located.

Thanks,
David Garske, wolfSSL

@dgarske
Copy link
Contributor

dgarske commented Jul 25, 2023

@topazus , thanks for the email and while the contributor agreement is in progress, I am asking @JacobBarthelmeh to review this.

@dgarske
Copy link
Contributor

dgarske commented Jul 25, 2023

ZD 16480

@dgarske dgarske assigned JacobBarthelmeh and unassigned dgarske Jul 25, 2023
@embhorn
Copy link
Member

embhorn commented Aug 8, 2023

Hi @topazus

I sent the contributor agreement form to you from our ZenDesk portal. Have you had a chance to review it?

@JacobBarthelmeh
Copy link
Contributor

Closing this stale pull request. Contributor agreement status did not get resolved and unit tests have since been added to cmake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants