20230724-cppcheck-2v11 #6652
Merged
20230724-cppcheck-2v11 #6652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated, and legacyUninitvar suppressed globally (as before): src/internal.c:wolfSSL_DtlsUpdateWindow(): shiftTooManyBitsSigned and integerOverflowCond (true positive, fixed); src/ssl.c:wolfSSL_GetSessionFromCache(): autoVariables (true positive, intentional and now suppressed); wolfcrypt/src/asn.c: several uninitvars in EccSpecifiedECDomainDecode(), wc_EccPrivateKeyDecode(), DecodeSingleResponse(), and DecodeResponseData() (false positives due to bug in cppcheck short circuit eval analysis, mitigated by refactoring && expressions to nested-if constructs that are semantically identical); src/ssl.c:wolfSSL_GetSessionFromCache(): nullPointer (false positive due to bug in cppcheck value flow analysis, workarounded).
|
|
|
retest this please |
JacobBarthelmeh
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes and workarounds for
cppcheck2.11 withuninitvarchecks reactivated, andlegacyUninitvarsuppressed globally (as before):src/internal.c:wolfSSL_DtlsUpdateWindow():shiftTooManyBitsSignedandintegerOverflowCond(true positive, fixed);src/ssl.c:wolfSSL_GetSessionFromCache():autoVariables(true positive, intentional and now suppressed);wolfcrypt/src/asn.c: severaluninitvarsinEccSpecifiedECDomainDecode(),wc_EccPrivateKeyDecode(),DecodeSingleResponse(), andDecodeResponseData()(false positives due to bug incppcheckshort circuit eval analysis, mitigated by refactoring&&expressions to nested-ifconstructs that are semantically identical);src/ssl.c:wolfSSL_GetSessionFromCache():nullPointer(false positive due to bug incppcheckvalue flow analysis, workarounded).tested with
wolfssl-multi-test.sh ... super-quick-check 'cppcheck-.*'note, I'm opening tickets upstream with
cppcheckaround the bugs in short-circuit evaluation and ValueFlow.