XCODE support for v5.2.3 of the FIPS module #7140
Conversation
|
Jenkins Retest this please |
kaleb-himes
force-pushed
the
140-3-ARMv8-PAA-porting
branch
from
1bb0142
to
c20951b
Compare
kaleb-himes
changed the title
|
NOTE: After internal versioning discussion, changing version to v5.2.3 from v5.3.0 which is in contention with fips-ready and fips-dev |
IDE/XCODE-FIPSv5/user_settings.h
Outdated
| @@ -374,6 +432,7 @@ extern "C" { | |||
| #undef WOLFSSL_SHA3 | |||
| #if 1 | |||
| #define WOLFSSL_SHA3 | |||
| #define Sha3 wc_Sha3 | |||
There was a problem hiding this comment.
This should be handled in wolfssl/wolfcrypt/sha3.h as long as NO_OLD_WC_NAMES is not defined?
There was a problem hiding this comment.
sha3.h gets replaced by an older version of sha3.h when FIPS is checked out, unfortunately that older version doesn't handle this.
There was a problem hiding this comment.
Double checking to be sure.
There was a problem hiding this comment.
Ope, I was wrong. Good catch, thank you! Updated user_settings.h to define NO_OLD_WC_NAMES.
|
This looks good, @kaleb-himes please rebase it onto master branch when you get a chance and resolve the merge conflict. |
kaleb-himes
force-pushed
the
140-3-ARMv8-PAA-porting
branch
from
c20951b
to
2e1c954
Compare
kaleb-himes
force-pushed
the
140-3-ARMv8-PAA-porting
branch
from
2e1c954
to
610af43
Compare
|
rebased on Jun 21 2024 |
Description
Fixes some warnings found by XCODE and adds options for customer(s) who will be depending on v5.3.0 of the FIPS module.
Testing
See fips repo for test applications, full harness and optesting done in-house, ready to go to a CSTL for review
Checklist