Fixup places where it should be CCM instead of GCM. #7218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparkiDev
reviewed
Feb 6, 2024
SparkiDev
reviewed
Feb 6, 2024
wolfssl/internal.h
Outdated
| @@ -1743,6 +1743,7 @@ enum Misc { | |||
| AES_CCM_16_AUTH_SZ = 16, /* AES-CCM-16 Auth Tag length */ | |||
| AES_CCM_8_AUTH_SZ = 8, /* AES-CCM-8 Auth Tag Length */ | |||
| AESCCM_NONCE_SZ = 12, | |||
| CCM_IMP_IV_SZ = 4, /* Size of GCM/CCM AEAD implicit IV */ | |||
There was a problem hiding this comment.
Fix the comment on this to be only CCM.
Fix the comment for GCM_IMP_IV_SZ to be only GCM.
There was a problem hiding this comment.
Please fix comment. Then we can accept this PR.
dgarske
requested changes
May 15, 2024
wolfssl/internal.h
Outdated
| @@ -1743,6 +1743,7 @@ enum Misc { | |||
| AES_CCM_16_AUTH_SZ = 16, /* AES-CCM-16 Auth Tag length */ | |||
| AES_CCM_8_AUTH_SZ = 8, /* AES-CCM-8 Auth Tag Length */ | |||
| AESCCM_NONCE_SZ = 12, | |||
| CCM_IMP_IV_SZ = 4, /* Size of GCM/CCM AEAD implicit IV */ | |||
There was a problem hiding this comment.
Please fix comment. Then we can accept this PR.
dgarske
approved these changes
May 15, 2024
There was a problem hiding this comment.
This PR doesn't appear to fix anything, but is an acceptable cleanup. Over to @SparkiDev for final.
Yes, was in response to a github bug report. |
|
jenkins retest this please |
SparkiDev
approved these changes
May 15, 2024
jefferyq2
pushed a commit
to jefferyq2/wolfssl
that referenced
this pull request
Jun 9, 2024
Fixup places where it should be CCM instead of GCM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7216