Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

20240314 -- fix -Wconversions in asn.c #7336

Merged
merged 1 commit into from
Mar 15, 2024
Merged

20240314 -- fix -Wconversions in asn.c #7336

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions wolfcrypt/src/asn.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1128,9 +1128,9 @@ static int GetASN_BitString(const byte* input, word32 idx, int length)
static int GetASN_UTF8String(const byte* input, word32 idx, int length)
{
int ret = 0;
int i = 0;
word32 i = 0;

while ((ret == 0) && (i < length)) {
while ((ret == 0) && ((int)i < length)) {
int cnt;

/* Check code points and get count of following bytes. */
Expand All @@ -1157,7 +1157,7 @@ static int GetASN_UTF8String(const byte* input, word32 idx, int length)
/* Check each following byte. */
for (; cnt > 0; cnt--) {
/* Check we have enough data. */
if (i == length) {
if ((int)i == length) {
WOLFSSL_MSG("Missing character in UTF8STRING\n");
ret = ASN_PARSE_E;
break;
Expand Down Expand Up @@ -1202,7 +1202,7 @@ static int GetASN_ObjectId(const byte* input, word32 idx, int length)
/* Last octet of a subidentifier has bit 8 clear. Last octet must be last
* of a subidentifier. Ensure last octet hasn't got top bit set indicating.
*/
else if ((input[idx + length - 1] & 0x80) != 0x00) {
else if ((input[(int)idx + length - 1] & 0x80) != 0x00) {
WOLFSSL_MSG("OID last octet has top bit set");
ret = ASN_PARSE_E;
}
Expand Down
Loading