workaround for Ubuntu runner, high entropy + ASLR #7340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
dgarske
requested changes
Mar 15, 2024
.github/workflows/krb5.yml
Outdated
| - name: Build wolfSSL | ||
| uses: wolfSSL/actions-build-autotools-project@v1 | ||
| with: | ||
| path: wolfssl | ||
| configure: --enable-krb CFLAGS='-fsanitize=address' | ||
| configure: --enable-krb CC='gcc-11' CFLAGS='-fsanitize=address' |
There was a problem hiding this comment.
I prefer CC="gcc-11 -fsanitize=address" or CC="gcc-11" CFLAGS="-fsanitize=address" LDFLAGS="-fsanitize=address". I saw an issue with this because linker LDFLAGS did not have sanitizer also set.
JacobBarthelmeh
force-pushed
the
github_tests
branch
2 times, most recently
from
039f27d
to
68eb5c6
Compare
JacobBarthelmeh
force-pushed
the
github_tests
branch
from
68eb5c6
to
5106cb1
Compare
JacobBarthelmeh
changed the title
|
Turned out to be this issue (actions/runner-images#9491), not related to timeout. Time out's were being hit because when autoconf ran conftest.c it would get in a loop of DEADLYSIGNAL errors due to a bad mix of high-entropy + ASLR + older LLVM version. Added the work around for now. |
dgarske
approved these changes
Mar 17, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checked --enable-openvpn benchmark from v5.6.6-stable to master and did not see any obvious performance degradation in crypto operations.