hostap update #7446
Merged
hostap update #7446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
julek-wolfssl
commented
Apr 18, 2024
julek-wolfssl
commented
- Implement PACs for EAP-FAST
- wolfSSL_set_session_ticket_ext_cb
- server side wolfSSL_set_session_secret_cb (tls <=1.2 only)
- Filter cipher list on TLS version change
- Remove unused internal API
- Advertise all supported sigalgs by default
- Expose *_set_groups for TLS < 1.3
julek-wolfssl
force-pushed
the
hostap
branch
4 times, most recently
from
de66aeb
to
a82f54b
Compare
|
Retest this please. |
julek-wolfssl
force-pushed
the
hostap
branch
4 times, most recently
from
87eee35
to
05d9c6c
Compare
dgarske
requested changes
Apr 26, 2024
| /* use wolfSSL_API visibility to be able to test in tests/api.c */ | ||
| WOLFSSL_API void InitSuitesHashSigAlgo_ex2(byte* hashSigAlgo, int have, | ||
| WOLFSSL_API void InitSuitesHashSigAlgo(byte* hashSigAlgo, int have, |
There was a problem hiding this comment.
This is marked as a public API. Should it be just to appease tests/api.c?
There was a problem hiding this comment.
Yes that is exactly why that is. We need a better way to mark that.
There was a problem hiding this comment.
I like this cleanup and I agree the api.c should be the only one using this API. It could come up as a red flag at release time, but let's take it.
- Add test to make sure we fail on curve mismatch
Remove tests that fail with openssl
dgarske
approved these changes
May 13, 2024
| /* use wolfSSL_API visibility to be able to test in tests/api.c */ | ||
| WOLFSSL_API void InitSuitesHashSigAlgo_ex2(byte* hashSigAlgo, int have, | ||
| WOLFSSL_API void InitSuitesHashSigAlgo(byte* hashSigAlgo, int have, |
There was a problem hiding this comment.
I like this cleanup and I agree the api.c should be the only one using this API. It could come up as a red flag at release time, but let's take it.
jefferyq2
pushed a commit
to jefferyq2/wolfssl
that referenced
this pull request
Jun 9, 2024
hostap update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.