-
Notifications
You must be signed in to change notification settings - Fork 832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add global heap hint setter function #7478
Conversation
c59274f
to
d68f3cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is great. What's holding it up?
wolfcrypt/src/memory.c
Outdated
|
||
|
||
/* returns a pointer to the current global heap hint */ | ||
void* wolfSSL_GetGlobalHeapHint() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(void)
.
Restest this please Jenkins |
I don't like that a retest needed done. Will need to keep an eye out for if the tests are having a threading issue with the setting of the global heap hint (is why I limited the set global heap hint test). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JacobBarthelmeh please make sure the static memory / user manual adds a few lines about these new APIs. Very handy addition.
add global heap hint setter function
No description provided.