Benchmark, SM3: fix full hash testing #7493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test now has an array of hashes. Use only first hash when testing full digest operation.
|
retest this please |
Variables may not be initialized in benchmark test when building for small stack.
Set the curve explicitly if it is SM2. Set the key type to signature algorithm to handle SM2.
|
retest this please |
1 similar comment
|
retest this please |
douzzer
requested changes
May 9, 2024
There was a problem hiding this comment.
This all looks fine, but I can't get a proper read on whether it works because of preexisting defects in the wolfsm code.
I've implemented several tests for it in the usual way, and the initial report is
65a2e5265c-multi-test-log.html.gz
From the looks of it, most of the fixes will be to the wolfsm repo. Assign the wolfsm fixit PR(s) to me when they're ready.
Pass around the algorithm id from the private key so that the WOLFSSL or WOLFSSL_CTX get the correct key format set. Use different verification context when self-signed certificate with SM2 and SM3 signature but public key OID is ECC.
SparkiDev
force-pushed
the
sm3_benchmark_fix
branch
from
694386c
to
add7428
Compare
|
retest this please |
|
Let me know if there are further clang-tidy fixes required. |
douzzer
approved these changes
May 13, 2024
jefferyq2
pushed a commit
to jefferyq2/wolfssl
that referenced
this pull request
Jun 9, 2024
Benchmark, SM3: fix full hash testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test now has an array of hashes.
Use only first hash when testing full digest operation.
Testing
Install SM code.
./configure --enable-sm3
make
Checklist