20240512-pkcs12_test-leak #7524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix unconditional memory leak in pkcs12_test(). * refactor pkcs12_test() to fix error-conditional memory leaks. * fix various old-style return codes in sm4_ccm_test(), pkcs12_test(), prf_test(), tls12_kdf_test(), xmss_test(), xmss_test_verify_only(), lms_test(), and lms_test_verify_only().
|
retest this please |
SparkiDev
approved these changes
May 12, 2024
jefferyq2
pushed a commit
to jefferyq2/wolfssl
that referenced
this pull request
Jun 9, 2024
20240512-pkcs12_test-leak
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wolfcrypt/test/test.c:pkcs12_test().pkcs12_test()to fix error-conditional memory leaks.sm4_ccm_test(),pkcs12_test(),prf_test(),tls12_kdf_test(),xmss_test(),xmss_test_verify_only(),lms_test(), andlms_test_verify_only().tested with
wolfssl-multi-test.sh ... super-quick-check linuxkm-aesni-insmod-kmemleak sp-all-asm-smallstack-valgrind-testsuite sanitizer-all-intelasm-c-fallback-fuzzernote: weirdly, the memory leak in
pkcs12_test()was only detected by the nightly kmemleak tests (linuxkm-noasm-insmod-kmemleakandlinuxkm-aesni-insmod-kmemleak), not by any of the sanitizer or valgrind runs.