Test case for wc_HpkeGenerateKeyPair() NULL argument #7571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgarske
requested changes
May 22, 2024
dgarske
requested changes
May 23, 2024
wolfcrypt/test/test.c
Outdated
| @@ -27521,6 +27521,15 @@ static wc_test_ret_t hpke_test_single(Hpke* hpke) | |||
| ret = WC_TEST_RET_ENC_EC(ret); | |||
| } | |||
|
|
|||
| /* NULL argument results in failure */ | |||
There was a problem hiding this comment.
In comment please indicate this is a negative test case. I'd like to see additional tests for the other 2 arguments also. Negative test cases need to be at the bottom or top of function. The code bellow assumes a properly setup hpke variable.
dgarske
approved these changes
May 23, 2024
cconlon
approved these changes
Jun 5, 2024
jefferyq2
pushed a commit
to jefferyq2/wolfssl
that referenced
this pull request
Jun 9, 2024
Test case for wc_HpkeGenerateKeyPair() NULL argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added NULL argument test case for wc_HpkeGenerateKeyPair().