Rewrite pattern matching to use explicit length #7604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pecting NULL terminated strings, thus replicating the behavior of openssl X509_check_host()
…ore tests for . handling
…t_len_pattern_match
|
Retest this please |
dgarske
approved these changes
May 31, 2024
dgarske
requested changes
May 31, 2024
dgarske
approved these changes
Jun 3, 2024
jefferyq2
pushed a commit
to jefferyq2/wolfssl
that referenced
this pull request
Jun 9, 2024
…n_match Rewrite pattern matching to use explicit length
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rewrite pattern matching to always use explicit lengths instead of expecting NULL terminated strings, thus replicating the behavior of openssl X509_check_host(). This rewrite fixes a buffer overread of size 1 to read the NULL terminator, in addition to fixing the issue of some strings matching or not matching incorrectly.
Fixes ZD 17987 which was only partially fixed by PR#7534.
Checklist