Fix for #7606: ESP_LOGI typo in esp32_sha.c #7607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgarske
approved these changes
May 31, 2024
jefferyq2
pushed a commit
to jefferyq2/wolfssl
that referenced
this pull request
Jun 9, 2024
Fix for wolfSSL#7606: ESP_LOGI typo in esp32_sha.c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thank you @Jreuningschererhubbell for reporting the ESP32 typo.
Fixes #7606
Edit: also consistently casts
(uintptr_t)ctxinstead of(unsigned)ctxfor the same statement.Fixes zd# n/a
Testing
How did you test?
Manually defined
#define WOLFSSL_ESP32_HW_LOCK_DEBUGin the wolfssl_test user_settings.h and confirmed compile success.Searched for other instances of
SP_LOGwith a leading space. None found.Checklist