Cortex-M inline assembly: labels with unique number appended #7649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When functions are inlined, the labels need to be unique. Putting '%=' on the end of the label ensures that the compilers appends a unique number to the end.
dgarske
reviewed
Jun 17, 2024
| @@ -101,7 +101,7 @@ void Transform_Sha256_Len(wc_Sha256* sha256, const byte* data, word32 len) | |||
| "STRD r10, r11, [sp, #88]\n\t" | |||
| /* Start of loop processing a block */ | |||
| "\n" | |||
| "L_SHA256_transform_len_begin:\n\t" | |||
| "L_SHA256_transform_len_begin%=:\n\t" | |||
There was a problem hiding this comment.
Have you confirmed this works with compilers like IAR? Let me know if you need some help testing that.
There was a problem hiding this comment.
I haven't checked IAR and would really appreciate it if you could try it out!
DGA45
approved these changes
Jun 18, 2024
dgarske
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When functions are inlined, the labels need to be unique. Putting '%=' on the end of the label ensures that the compilers appends a unique number to the end.
Fixes #7645
Testing
./configure '--disable-shared' 'LDFLAGS=--static' '--host=armv7m' 'CC=arm-linux-gnueabi-gcc' '--enable-sp' '--enable-sp-asm' '--enable-armasm=inline' 'host_alias=armv7m'
Checklist