SP Intel x64 ASM: fixes #7666
Merged
SP Intel x64 ASM: fixes #7666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't use RIP relative with XMM/YMM instructions. For MSVC asm, explicitly state type for pointer. For MSVC asm, don't use vmodvqu for saving XMM registers unless this is AVX2 code.
This was referenced Jun 19, 2024
ilka1999
approved these changes
Jun 20, 2024
JacobBarthelmeh
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Don't use RIP relative with XMM/YMM instructions.
For MSVC asm, explicitly state type for pointer.
For MSVC asm, don't use vmodvqu for saving XMM registers unless this is AVX2 code.
Fixes #7661, #7663
Testing
./configure '--disable-shared' '--enable-sp' '--enable-sp-asm'
make test
Checklist