Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renesas RX TSIP ECDSA support #7685

Merged
merged 12 commits into from
Jul 19, 2024
Merged

Conversation

dgarske
Copy link
Contributor

@dgarske dgarske commented Jun 26, 2024

Description

Support for Renesas RX TSIP with ECDSA and Crypto Callbacks.

  • Fix building ECC with NO_ASN (./configure --enable-cryptonly --disable-rsa --disable-asn --disable-examples). Adds support for raw R+S signature.
  • Fix for building WOLFSSL_RENESAS_TSIP_CRYPTONLY and NO_WOLFSSL_RENESAS_TSIP_CRYPT_HASH.
  • Revert built-in wc_GenerateSeed support for RX TSIP removed in Update random generation on RX TSIP #6851.
  • Updated example key data for private key for client authentication

Testing

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

Fix building ECC with NO_ASN (`./configure --enable-cryptonly --disable-rsa --disable-asn --disable-examples`).
@dgarske dgarske self-assigned this Jun 26, 2024
@dgarske dgarske marked this pull request as ready for review June 27, 2024 20:31
@dgarske dgarske requested review from kojo1 and miyazakh June 27, 2024 20:31
@dgarske
Copy link
Contributor Author

dgarske commented Jun 27, 2024

@kojo1 or @miyazakh can you review these changes and possibly test them out with e2Studio. I want to make sure I didn't break anything.

@dgarske
Copy link
Contributor Author

dgarske commented Jul 1, 2024

Retest this please

…EccKeyPair incorrect free of key if TSIP not used (ZD18222).
@dgarske
Copy link
Contributor Author

dgarske commented Jul 5, 2024

Retest this please

@dgarske dgarske removed their assignment Jul 9, 2024
miyazakh
miyazakh previously approved these changes Jul 10, 2024
@miyazakh
Copy link
Contributor

Hi @dgarske
Confirmed that tests including client/server example are passed.

@miyazakh
Copy link
Contributor

Retest this please

@dgarske dgarske assigned JacobBarthelmeh and unassigned miyazakh Jul 10, 2024
@dgarske dgarske removed their assignment Jul 15, 2024
@dgarske dgarske requested review from miyazakh and removed request for kojo1 July 15, 2024 21:12
dgarske added a commit to dgarske/wolfBoot that referenced this pull request Jul 17, 2024
…CC compiler.

* Added initialization of the clocks and UART driver.
   - wolfBoot uses on chip high speed oscillator (HOCO) at (120MHz RX65N and 240Mhz for RX72N).
* Added RX RSPI and QSPI driver support with external SPI flash
* Improve documentation and fix spelling errors.
* Added .srec (s-record) format support
* Added RX TSIP support for ECDSA (requires wolfSSL/wolfssl#7685).
* Allow custom implementation of `get_trailer_at`, `set_trailer_at` and `set_partition_magic` using `CUSTOM_PARTITION_TRAILER`
danielinux pushed a commit to wolfSSL/wolfBoot that referenced this pull request Jul 17, 2024
…CC compiler.

* Added initialization of the clocks and UART driver.
   - wolfBoot uses on chip high speed oscillator (HOCO) at (120MHz RX65N and 240Mhz for RX72N).
* Added RX RSPI and QSPI driver support with external SPI flash
* Improve documentation and fix spelling errors.
* Added .srec (s-record) format support
* Added RX TSIP support for ECDSA (requires wolfSSL/wolfssl#7685).
* Allow custom implementation of `get_trailer_at`, `set_trailer_at` and `set_partition_magic` using `CUSTOM_PARTITION_TRAILER`
@dgarske dgarske requested a review from SparkiDev July 18, 2024 15:47
@miyazakh
Copy link
Contributor

Confirmed that tests including client/server example are passed on the latest change

miyazakh
miyazakh previously approved these changes Jul 18, 2024
@dgarske
Copy link
Contributor Author

dgarske commented Jul 18, 2024

@miyazakh if you are happy with the PR please indicate approved. I'd like to get this PR merged in soon.

@SparkiDev
Copy link
Contributor

retest this please

@SparkiDev SparkiDev merged commit e6fcd48 into wolfSSL:master Jul 19, 2024
119 checks passed
@dgarske dgarske deleted the renesas_rx_tsip branch August 13, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants