Sni csharp wrapper patch #7692
Merged
Sni csharp wrapper patch #7692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgarske
requested changes
Jun 27, 2024
| /* print out results of TLS/SSL accept */ | ||
| Console.WriteLine("SSL version is " + wolfssl.get_version(ssl)); | ||
| Console.WriteLine("SSL cipher suite is " + wolfssl.get_current_cipher(ssl)); | ||
|
|
||
| /* read and print out the message then reply */ | ||
| if (wolfssl.read(ssl, buff, 1023) < 0) | ||
| if (wolfssl.read(ssl, buff, 1024) < 0) |
There was a problem hiding this comment.
The point of reading 1023 is to leave a null terminator. Buff is 1024, so this is 1024-1. We use this same pattern in a few of the examples.
| IntPtr result = Marshal.AllocHGlobal(32); | ||
| IntPtr inOutSz = Marshal.AllocHGlobal(sizeof(int)); | ||
| Marshal.WriteInt32(inOutSz, 32); | ||
| byte [] buffer = { /* www.paypal.com */ |
There was a problem hiding this comment.
Please avoid the full link, just say from PayPal website client hello. Is there a reason you didn't use our own or something not money related like google.com?
dgarske
approved these changes
Jun 27, 2024
JacobBarthelmeh
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes zd#17990
Testing
server:
client:
Checklist