Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ASAN warning with compatibility layer cipher list parsing #7698

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Fix ASAN warning with compatibility layer cipher list parsing #7698

merged 1 commit into from
Jul 2, 2024

Conversation

dgarske
Copy link
Contributor

@dgarske dgarske commented Jun 28, 2024 •
edited
Loading

Description

  • Fix for ASAN warning with compatibility layer cipher lists in ParseCipherList and CheckcipherList.
wolfssl/src/ssl.c:11892:16: runtime error: applying non-zero offset 1 to null pointer
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior wolfssl/src/ssl.c:11892:16 in

wolfssl/src/internal.c:26632:16: runtime error: applying non-zero offset 1 to null pointer
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior wolfssl/src/internal.c:26632:16 in

ZD 18175

  • Added test case for ASAN to trigger NULL + 1 warning.
  • Cleanup messy WOLFSSL_TIRTOS in api.c.

Testing

./configure CC="clang -fsanitize=address" --enable-all && make check

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@dgarske dgarske mentioned this pull request Jun 28, 2024
Closed
@dgarske
Copy link
Contributor Author

dgarske commented Jun 28, 2024

Retest this please

@dgarske
Fix for ASAN warning with compatibility layer lists in `ParseCipherLi…
7faf0dc 
…st` and `CheckcipherList` (ZD 18175). Add test case for ASAN to trigger NULL + 1 warning. Cleanup messy `WOLFSSL_TIRTOS` in api.c.
@dgarske
Copy link
Contributor Author

dgarske commented Jul 1, 2024

Retest this please

@dgarske dgarske removed their assignment Jul 1, 2024
@JacobBarthelmeh JacobBarthelmeh merged commit 6409b68 into wolfSSL:master Jul 2, 2024
119 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobBarthelmeh JacobBarthelmeh JacobBarthelmeh approved these changes

Assignees

@wolfSSL-Bot wolfSSL-Bot

Labels
For This Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgarske @JacobBarthelmeh @wolfSSL-Bot